Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: sync/internal_api/public/engine/model_safe_worker.h

Issue 640853008: Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed hang in the unit test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/engine/model_safe_worker.h
diff --git a/sync/internal_api/public/engine/model_safe_worker.h b/sync/internal_api/public/engine/model_safe_worker.h
index 03970b91fe0dd48a84e903fbe55e6e8c65292d42..ad84d4925cffae2f49fcaacf4c97e3eb7084c78a 100644
--- a/sync/internal_api/public/engine/model_safe_worker.h
+++ b/sync/internal_api/public/engine/model_safe_worker.h
@@ -133,7 +133,13 @@ class SYNC_EXPORT ModelSafeWorker
// observation from sync thread when shutting down sync.
base::Lock working_loop_lock_;
base::MessageLoop* working_loop_;
- base::WaitableEvent working_loop_set_wait_;
+
+ // Callback passed with UnregisterForLoopDestruction. Normally this
+ // remains unset/unused and is stored only if |working_loop_| isn't
+ // initialized by the time UnregisterForLoopDestruction is called.
+ // It is safe to copy and thread safe.
+ // See comments in model_safe_worker.cc for more details.
+ base::Callback<void(ModelSafeGroup)> unregister_done_callback_;
};
// A map that details which ModelSafeGroup each ModelType

Powered by Google App Engine
This is Rietveld 408576698