Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 640853007: Add rudimentary support for ASan's intra-object-overflow detection. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
CC:
chromium-reviews, kcc2
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add rudimentary support for ASan's intra-object-overflow detection. Also, add an ASan blacklist. BUG=425374 R=glider@chromium.org Committed: https://crrev.com/78507b971d25db9d18e3722a21de814280dc4ca6 Cr-Commit-Position: refs/heads/master@{#300882}

Patch Set 1 #

Patch Set 2 : blacklist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M build/common.gypi View 1 4 chunks +15 lines, -0 lines 0 comments Download
A tools/memory/asan/blacklist.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
earthdok
ptal. this is Linux only.
6 years, 2 months ago (2014-10-21 14:58:22 UTC) #1
earthdok
added a blacklist
6 years, 2 months ago (2014-10-21 15:57:43 UTC) #2
Alexander Potapenko
LGTM I think we may need to explicitly mention that the blacklist isn't to be ...
6 years, 2 months ago (2014-10-22 17:24:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640853007/20001
6 years, 2 months ago (2014-10-22 17:26:18 UTC) #5
earthdok
On 2014/10/22 17:24:32, Alexander Potapenko wrote: > LGTM > > I think we may need ...
6 years, 2 months ago (2014-10-22 17:36:24 UTC) #6
Alexander Potapenko
On 2014/10/22 17:36:24, earthdok wrote: > On 2014/10/22 17:24:32, Alexander Potapenko wrote: > > LGTM ...
6 years, 2 months ago (2014-10-22 17:56:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/5341)
6 years, 2 months ago (2014-10-22 18:33:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640853007/20001
6 years, 2 months ago (2014-10-23 12:20:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 14:00:22 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 14:00:52 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78507b971d25db9d18e3722a21de814280dc4ca6
Cr-Commit-Position: refs/heads/master@{#300882}

Powered by Google App Engine
This is Rietveld 408576698