Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640853005: Simplify QuicUnackedPacketMap to expose AddSentPacket, instead of (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Making_whole_host_of_QUIC_framing_errors_77961885
Project:
chromium
Visibility:
Public.

Description

Simplify QuicUnackedPacketMap to expose AddSentPacket, instead of AddPacket, OnRetransmittedPacket, and SetSent. Merge internal change: 77986449 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -146 lines) Patch
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +24 lines, -32 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_unacked_packet_map.h View 3 chunks +21 lines, -19 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 4 chunks +39 lines, -44 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 14 chunks +69 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-20 21:21:39 UTC) #1
Ryan Hamilton
6 years, 2 months ago (2014-10-20 21:25:16 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698