|
|
Created:
6 years, 2 months ago by jam Modified:
6 years, 2 months ago Reviewers:
M-A Ruel CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/build.git/+/master Project:
tools Visibility:
Public. |
DescriptionEnable swarming on Vista tester.
BUG=414808
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 24 (11 generated)
jam@chromium.org changed reviewers: + maruel@chromium.org
lgtm
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640833003/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for scripts/slave/recipe_modules/chromium/chromium_win.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A scripts Created missing directory scripts. A scripts/slave Created missing directory scripts/slave. A scripts/slave/recipe_modules Created missing directory scripts/slave/recipe_modules. A scripts/slave/recipe_modules/chromium Created missing directory scripts/slave/recipe_modules/chromium. can't find file to patch at input line 6 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: scripts/slave/recipe_modules/chromium/chromium_win.py |diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py |index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 |--- a/scripts/slave/recipe_modules/chromium/chromium_win.py |+++ b/scripts/slave/recipe_modules/chromium/chromium_win.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Patch: scripts/slave/recipe_modules/chromium/chromium_win.py Index: scripts/slave/recipe_modules/chromium/chromium_win.py diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 --- a/scripts/slave/recipe_modules/chromium/chromium_win.py +++ b/scripts/slave/recipe_modules/chromium/chromium_win.py @@ -62,10 +62,16 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], + 'tests': [ + steps.MojoPythonTests(), + steps.TelemetryUnitTests(), + steps.TelemetryPerfUnitTests(), + ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win', }, + 'enable_swarming': True, 'swarming_dimensions': { 'os': 'Windows-6.0', }, @@ -81,11 +87,6 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], - 'tests': [ - steps.MojoPythonTests(), - steps.TelemetryUnitTests(), - steps.TelemetryPerfUnitTests(), - ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win',
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640833003/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for scripts/slave/recipe_modules/chromium/chromium_win.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A scripts Created missing directory scripts. A scripts/slave Created missing directory scripts/slave. A scripts/slave/recipe_modules Created missing directory scripts/slave/recipe_modules. A scripts/slave/recipe_modules/chromium Created missing directory scripts/slave/recipe_modules/chromium. can't find file to patch at input line 6 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: scripts/slave/recipe_modules/chromium/chromium_win.py |diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py |index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 |--- a/scripts/slave/recipe_modules/chromium/chromium_win.py |+++ b/scripts/slave/recipe_modules/chromium/chromium_win.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Patch: scripts/slave/recipe_modules/chromium/chromium_win.py Index: scripts/slave/recipe_modules/chromium/chromium_win.py diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 --- a/scripts/slave/recipe_modules/chromium/chromium_win.py +++ b/scripts/slave/recipe_modules/chromium/chromium_win.py @@ -62,10 +62,16 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], + 'tests': [ + steps.MojoPythonTests(), + steps.TelemetryUnitTests(), + steps.TelemetryPerfUnitTests(), + ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win', }, + 'enable_swarming': True, 'swarming_dimensions': { 'os': 'Windows-6.0', }, @@ -81,11 +87,6 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], - 'tests': [ - steps.MojoPythonTests(), - steps.TelemetryUnitTests(), - steps.TelemetryPerfUnitTests(), - ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win',
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640833003/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for scripts/slave/recipe_modules/chromium/chromium_win.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A scripts Created missing directory scripts. A scripts/slave Created missing directory scripts/slave. A scripts/slave/recipe_modules Created missing directory scripts/slave/recipe_modules. A scripts/slave/recipe_modules/chromium Created missing directory scripts/slave/recipe_modules/chromium. can't find file to patch at input line 6 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: scripts/slave/recipe_modules/chromium/chromium_win.py |diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py |index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 |--- a/scripts/slave/recipe_modules/chromium/chromium_win.py |+++ b/scripts/slave/recipe_modules/chromium/chromium_win.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Patch: scripts/slave/recipe_modules/chromium/chromium_win.py Index: scripts/slave/recipe_modules/chromium/chromium_win.py diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 --- a/scripts/slave/recipe_modules/chromium/chromium_win.py +++ b/scripts/slave/recipe_modules/chromium/chromium_win.py @@ -62,10 +62,16 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], + 'tests': [ + steps.MojoPythonTests(), + steps.TelemetryUnitTests(), + steps.TelemetryPerfUnitTests(), + ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win', }, + 'enable_swarming': True, 'swarming_dimensions': { 'os': 'Windows-6.0', }, @@ -81,11 +87,6 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], - 'tests': [ - steps.MojoPythonTests(), - steps.TelemetryUnitTests(), - steps.TelemetryPerfUnitTests(), - ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win',
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640833003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for scripts/slave/recipe_modules/chromium/chromium_win.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A scripts Created missing directory scripts. A scripts/slave Created missing directory scripts/slave. A scripts/slave/recipe_modules Created missing directory scripts/slave/recipe_modules. A scripts/slave/recipe_modules/chromium Created missing directory scripts/slave/recipe_modules/chromium. can't find file to patch at input line 6 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: scripts/slave/recipe_modules/chromium/chromium_win.py |diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py |index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 |--- a/scripts/slave/recipe_modules/chromium/chromium_win.py |+++ b/scripts/slave/recipe_modules/chromium/chromium_win.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Patch: scripts/slave/recipe_modules/chromium/chromium_win.py Index: scripts/slave/recipe_modules/chromium/chromium_win.py diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 --- a/scripts/slave/recipe_modules/chromium/chromium_win.py +++ b/scripts/slave/recipe_modules/chromium/chromium_win.py @@ -62,10 +62,16 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], + 'tests': [ + steps.MojoPythonTests(), + steps.TelemetryUnitTests(), + steps.TelemetryPerfUnitTests(), + ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win', }, + 'enable_swarming': True, 'swarming_dimensions': { 'os': 'Windows-6.0', }, @@ -81,11 +87,6 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], - 'tests': [ - steps.MojoPythonTests(), - steps.TelemetryUnitTests(), - steps.TelemetryPerfUnitTests(), - ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win',
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640833003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for scripts/slave/recipe_modules/chromium/chromium_win.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A scripts Created missing directory scripts. A scripts/slave Created missing directory scripts/slave. A scripts/slave/recipe_modules Created missing directory scripts/slave/recipe_modules. A scripts/slave/recipe_modules/chromium Created missing directory scripts/slave/recipe_modules/chromium. can't find file to patch at input line 6 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: scripts/slave/recipe_modules/chromium/chromium_win.py |diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py |index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 |--- a/scripts/slave/recipe_modules/chromium/chromium_win.py |+++ b/scripts/slave/recipe_modules/chromium/chromium_win.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Patch: scripts/slave/recipe_modules/chromium/chromium_win.py Index: scripts/slave/recipe_modules/chromium/chromium_win.py diff --git a/scripts/slave/recipe_modules/chromium/chromium_win.py b/scripts/slave/recipe_modules/chromium/chromium_win.py index 689ae1806efa97cbc22c9d3345b71ccf40d24006..c27371d2b58335d67052a1f057232a3087bdde99 100644 --- a/scripts/slave/recipe_modules/chromium/chromium_win.py +++ b/scripts/slave/recipe_modules/chromium/chromium_win.py @@ -62,10 +62,16 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], + 'tests': [ + steps.MojoPythonTests(), + steps.TelemetryUnitTests(), + steps.TelemetryPerfUnitTests(), + ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win', }, + 'enable_swarming': True, 'swarming_dimensions': { 'os': 'Windows-6.0', }, @@ -81,11 +87,6 @@ SPEC = { 'test_generators': [ steps.generate_gtest, ], - 'tests': [ - steps.MojoPythonTests(), - steps.TelemetryUnitTests(), - steps.TelemetryPerfUnitTests(), - ], 'parent_buildername': 'Win Builder', 'testing': { 'platform': 'win',
Message was sent while issue was closed.
reuploaded and landed in https://codereview.chromium.org/645033006 |