Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 640823005: DevTools: NetworkPanel: classify TextTracks as Other. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/network/network-toggle-type-filter-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 2c602ef7369e78270c40c77c8794ad2c7b552bb7..0dcf97f9cec7c70ce74892720cb6c190d8ccf7e3 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -179,6 +179,8 @@ WebInspector.NetworkLogView.prototype = {
var types = [];
for (var typeId in WebInspector.resourceTypes) {
var resourceType = WebInspector.resourceTypes[typeId];
+ if (resourceType === WebInspector.resourceTypes.TextTrack)
+ continue;
types.push({name: resourceType.name(), label: resourceType.categoryTitle()});
}
this._resourceTypeFilterUI = new WebInspector.NamedBitSetFilterUI(types, WebInspector.settings.networkResourceTypeFilters);
@@ -1480,7 +1482,10 @@ WebInspector.NetworkLogView.prototype = {
_applyFilter: function(node)
{
var request = node.request();
- if (!this._resourceTypeFilterUI.accept(request.resourceType().name()))
+ var resourceType = request.resourceType();
+ if (resourceType === WebInspector.resourceTypes.TextTrack)
+ resourceType = WebInspector.resourceTypes.Other;
+ if (!this._resourceTypeFilterUI.accept(resourceType.name()))
return false;
if (this._dataURLFilterUI.checked() && request.parsedURL.isDataURL())
return false;
« no previous file with comments | « LayoutTests/inspector/network/network-toggle-type-filter-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698