Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 640813002: Revert of Move remote platforms creation logic from android_browser_finder to platform (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move remote platforms creation logic from android_browser_finder to platform (patchset #9 id:260001 of https://codereview.chromium.org/522553002/) Reason for revert: Speculative revert due to regression. BUG=419901 Original issue's description: > Move remote platforms creation logic from android_browser_finder to platform > > Previously, creation of platforms is done in browser_finder > classes. This patch aims to detach the coupling between > creating browsers from platform by moving such methods to platform. > Also modify android_platform_backend so it owns the adb instance. > > SHERRIFS: reverting this patch will require reverting https://codereview.chromium.org/541693004/ first. > > BUG=413637 > > Committed: https://crrev.com/5289ba2d6a2c1eb3f429673ac0088f658d8aee5a > Cr-Commit-Position: refs/heads/master@{#296310} TBR=tonyg@chromium.org,nduca@chromium.org,dtu@chromium.org,achuith@chromium.org,chrishenry@google.com BUG=413637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -319 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 11 chunks +27 lines, -30 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 8 chunks +72 lines, -32 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 4 chunks +31 lines, -23 lines 0 comments Download
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/__init__.py View 3 chunks +19 lines, -21 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/android_device.py View 1 chunk +0 lines, -63 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/android_device_unittest.py View 1 chunk +0 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 4 chunks +10 lines, -41 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 2 chunks +41 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_device.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 2 chunks +3 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/device.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend.py View 1 chunk +1 line, -19 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest/system_stub.py View 5 chunks +9 lines, -34 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
nednguyen
6 years, 2 months ago (2014-10-08 18:05:15 UTC) #1
Created Revert of Move remote platforms creation logic from
android_browser_finder to platform

Powered by Google App Engine
This is Rietveld 408576698