Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 640803004: Add a basic DOMWindow base class and use it in WindowProxy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/Frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
new file mode 100644
index 0000000000000000000000000000000000000000..38f2a31aa2e8db7f95f088c12eac3b8caa3b5613
--- /dev/null
+++ b/Source/core/frame/DOMWindow.h
@@ -0,0 +1,21 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+namespace blink {
+
+class ScriptWrappable;
+
+class DOMWindow {
+public:
+ // Ideally, DOMWindow would be a ScriptWrappable. However, LocalDOMWindow
+ // already has a ScriptWrappable subclass via EventTargetWithInlineData. As
+ // a result, making DOMWindow a ScriptWrappable would force callers of
+ // ScriptWrappable methods on DOMWindow methods to disambiguate which base
+ // class to access the methods through. To avoid this trouble, DOMWindow
+ // exposes an interface method to convert the DOMWindow to a ScriptWrappable
+ // instead.
+ virtual ScriptWrappable* toScriptWrappable() = 0;
+};
+
+} // namespace blink
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/Frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698