Source/core/frame/DOMWindow.h - Issue 640803004: Add a basic DOMWindow base class and use it in WindowProxy.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/DOMWindow.h

Issue 640803004: Add a basic DOMWindow base class and use it in WindowProxy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move the member too Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 namespace blink {

	6

	7 class ScriptWrappable;

	8

	9 class DOMWindow {
	haraken 2014/10/22 00:59:14 I'm curious why DOMWindow can't inherit from Scrip I'm curious why DOMWindow can't inherit from ScriptWrappableBase? dcheng 2014/10/22 01:01:46 LocalDOMWindow is an EventTarget (and I don't thin Show quoted text On 2014/10/22 00:59:14, haraken wrote: > > I'm curious why DOMWindow can't inherit from ScriptWrappableBase? LocalDOMWindow is an EventTarget (and I don't think it makes sense for RemoteDOMWindow to be an EventTarget -- I don't think you can register an event listener on a cross-origin DOMWindow). If this was also a ScriptWrappable, then you would have to explicitly say you wanted to use the ScriptWrappableBase from EventTargetWithInlineData or the ScriptWrappableBase from DOMWindow.
	10 public:

	11 virtual ScriptWrappable* toScriptWrappable() = 0;

	12 };

	13

	14 } // namespace blink

OLD	NEW