Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 640723004: cleanup and optimize rect intersect routines (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

cleanup and optimize rect intersect routines BUG=skia: Committed: https://skia.googlesource.com/skia/+/1119c870651ccd34c0acb8fb2cdfad2c07d3116c

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup the new bench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -110 lines) Patch
A bench/GeometryBench.cpp View 1 1 chunk +115 lines, -0 lines 0 comments Download
M bench/RegionBench.cpp View 2 chunks +0 lines, -56 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkRect.h View 2 chunks +22 lines, -16 lines 0 comments Download
M src/core/SkRect.cpp View 2 chunks +15 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
6 years, 2 months ago (2014-10-09 19:46:27 UTC) #2
caryclark
https://codereview.chromium.org/640723004/diff/1/src/core/SkRect.cpp File src/core/SkRect.cpp (right): https://codereview.chromium.org/640723004/diff/1/src/core/SkRect.cpp#newcode110 src/core/SkRect.cpp:110: CHECK_INTERSECT(left, top, right, bottom, fLeft, fTop, fRight, fBottom); Is ...
6 years, 2 months ago (2014-10-09 20:19:47 UTC) #3
caryclark
lgtm
6 years, 2 months ago (2014-10-09 20:28:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640723004/120001
6 years, 2 months ago (2014-10-09 21:13:26 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 21:29:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as 1119c870651ccd34c0acb8fb2cdfad2c07d3116c

Powered by Google App Engine
This is Rietveld 408576698