Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Issue 640713003: Subzero: Improve the output with the --timing-focus=xxx option. (Closed)

Created:
6 years, 2 months ago by Jim Stichnoth
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Improve the output with the --timing-focus=xxx option. Makes sure the percentages represent only the function(s) focused on, and not with respect to the total translation time across all functions. Reset the timings between functions so that --timing-focus=* gives reasonable numbers. Also, adds a timer for the live range construction phase. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d14b1a027a88e1f54845fa5970c0bb462e01fcd4

Patch Set 1 #

Patch Set 2 : 80-col #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M src/IceCfg.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/IceCfgNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceGlobalContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/IceTimerTree.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/IceTimerTree.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/IceTimerTree.def View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years, 2 months ago (2014-10-08 14:09:00 UTC) #2
jvoung (off chromium)
lgtm
6 years, 2 months ago (2014-10-08 15:08:41 UTC) #3
Jim Stichnoth
6 years, 2 months ago (2014-10-08 15:28:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d14b1a027a88e1f54845fa5970c0bb462e01fcd4 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698