Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 640663005: Apply automatic range checks to content enum types across IPC [content/common/media] (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
Mike West, nasko
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to content enum types across IPC [content/common/media] This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/ee29132e89b284f780048ff839f2720d763018c8 Cr-Commit-Position: refs/heads/master@{#298869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/common/media/cdm_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/media/cdm_messages_enums.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-09 12:01:42 UTC) #2
Mike West
LGTM.
6 years, 2 months ago (2014-10-09 12:11:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640663005/1
6 years, 2 months ago (2014-10-09 12:12:21 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 13:04:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640663005/1
6 years, 2 months ago (2014-10-09 13:53:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 333ff70e6c3b850540e949ed894acf8fdd56470d
6 years, 2 months ago (2014-10-09 13:53:56 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:55:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee29132e89b284f780048ff839f2720d763018c8
Cr-Commit-Position: refs/heads/master@{#298869}

Powered by Google App Engine
This is Rietveld 408576698