Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 640663002: Replace OVERRIDE with its C++11 counterparts in src/printing (Closed)

Created:
6 years, 2 months ago by RAGHURAM
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE with its C++11 counterparts in src/printing This step is a giant search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Committed: https://crrev.com/a75cf358d98c8e3b242c00557f3da3dbfdbbe1ea Cr-Commit-Position: refs/heads/master@{#298864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M printing/backend/print_backend_chromeos.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
RAGHURAM
Please review. Thanks & Regards
6 years, 2 months ago (2014-10-08 10:57:31 UTC) #2
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-08 18:44:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640663002/1
6 years, 2 months ago (2014-10-08 18:45:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16395)
6 years, 2 months ago (2014-10-08 19:02:47 UTC) #7
Lei Zhang
Oh, is this your first patch? "r.nagaraj@samsung.com is not in AUTHORS file. If you are ...
6 years, 2 months ago (2014-10-08 19:09:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640663002/1
6 years, 2 months ago (2014-10-09 13:25:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as b29d38ba00320e17729013e88c00cb1fe5b659b6
6 years, 2 months ago (2014-10-09 13:29:56 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:31:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a75cf358d98c8e3b242c00557f3da3dbfdbbe1ea
Cr-Commit-Position: refs/heads/master@{#298864}

Powered by Google App Engine
This is Rietveld 408576698