Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 640633007: DevTools: fix "Disable Javascript" checkbox glitch. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1331 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 */ 1342 */
1343 function executionStatusCallback(error, status) 1343 function executionStatusCallback(error, status)
1344 { 1344 {
1345 if (error || !status) 1345 if (error || !status)
1346 return; 1346 return;
1347 1347
1348 var forbidden = (status === "forbidden"); 1348 var forbidden = (status === "forbidden");
1349 var disabled = forbidden || (status === "disabled"); 1349 var disabled = forbidden || (status === "disabled");
1350 1350
1351 this._disableJSInfo.classList.toggle("hidden", !forbidden); 1351 this._disableJSInfo.classList.toggle("hidden", !forbidden);
1352 this._disableJSCheckbox.checked = disabled;
1353 this._disableJSCheckbox.disabled = forbidden; 1352 this._disableJSCheckbox.disabled = forbidden;
1353 if (!forbidden && WebInspector.settings.javaScriptDisabled.get() !== disabled)
1354 WebInspector.settings.javaScriptDisabled.set(disabled);
aandrey 2014/10/17 12:11:51 don't you still need to update this._disableJSChec
eustas 2014/10/17 12:16:11 Nope. setting change is listened by checkbox itsel
1354 } 1355 }
1355 }, 1356 },
1356 1357
1357 __proto__: WebInspector.UISettingDelegate.prototype 1358 __proto__: WebInspector.UISettingDelegate.prototype
1358 } 1359 }
1359 1360
1360 /** 1361 /**
1361 * @constructor 1362 * @constructor
1362 * @implements {WebInspector.ActionDelegate} 1363 * @implements {WebInspector.ActionDelegate}
1363 */ 1364 */
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
1403 1404
1404 WebInspector.SourcesPanelFactory.prototype = { 1405 WebInspector.SourcesPanelFactory.prototype = {
1405 /** 1406 /**
1406 * @return {!WebInspector.Panel} 1407 * @return {!WebInspector.Panel}
1407 */ 1408 */
1408 createPanel: function() 1409 createPanel: function()
1409 { 1410 {
1410 return WebInspector.SourcesPanel.instance(); 1411 return WebInspector.SourcesPanel.instance();
1411 } 1412 }
1412 } 1413 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698