Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 640603005: <webview>: Add additional WebRequest API test coverage. (Closed)

Created:
6 years, 2 months ago by Fady Samuel
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

<webview>: Add additional WebRequest API test coverage. This CL adds a test which verifies that we read and change HTTP headers. BUG=352293 TBR=rockot@chromium.org Committed: https://crrev.com/b4110230c811dd23cc336c9d679c6c3d13a64440 Cr-Commit-Position: refs/heads/master@{#299047}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix appshell test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -0 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 4 chunks +35 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 3 chunks +48 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 4 chunks +35 lines, -0 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 3 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
Fady Samuel
6 years, 2 months ago (2014-10-08 16:39:50 UTC) #2
lfg
https://codereview.chromium.org/640603005/diff/1/chrome/browser/apps/web_view_browsertest.cc File chrome/browser/apps/web_view_browsertest.cc (right): https://codereview.chromium.org/640603005/diff/1/chrome/browser/apps/web_view_browsertest.cc#newcode564 chrome/browser/apps/web_view_browsertest.cc:564: embedded_test_server()->RegisterRequestHandler( The request handler should be defined in web_view_apitest.cc ...
6 years, 2 months ago (2014-10-08 17:23:31 UTC) #3
Fady Samuel
Wow, I was pointing WebViewAPITest to testWebRequestAPI and not testWebRequestAPIWithHeaders! The Appshell test was completely ...
6 years, 2 months ago (2014-10-08 19:18:50 UTC) #4
lfg
lgtm
6 years, 2 months ago (2014-10-08 19:21:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640603005/20001
6 years, 2 months ago (2014-10-08 19:25:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16414)
6 years, 2 months ago (2014-10-08 19:40:59 UTC) #9
fsamuel
6 years, 2 months ago (2014-10-08 19:41:42 UTC) #12
fsamuel
6 years, 2 months ago (2014-10-08 19:41:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640603005/20001
6 years, 2 months ago (2014-10-08 21:50:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/56244)
6 years, 2 months ago (2014-10-08 23:11:01 UTC) #17
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-09 00:01:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640603005/20001
6 years, 2 months ago (2014-10-10 01:37:59 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-10 02:41:07 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:42:24 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4110230c811dd23cc336c9d679c6c3d13a64440
Cr-Commit-Position: refs/heads/master@{#299047}

Powered by Google App Engine
This is Rietveld 408576698