src/compiler/representation-change.h - Issue 640603003: [turbofan] Properly emit bounds checks for typed array element loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/representation-change.h

Issue 640603003: [turbofan] Properly emit bounds checks for typed array element loads. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add another test. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/representation-change.h

diff --git a/src/compiler/representation-change.h b/src/compiler/representation-change.h

index f7b2ba63796629eca19369a8a9e95c0cdf3b9d74..3b6f183056fe57e4433f772b62e20b60df60f117 100644

--- a/src/compiler/representation-change.h

+++ b/src/compiler/representation-change.h

@@ -157,7 +157,7 @@ class RepresentationChanger {

node = jsgraph()->graph()->NewNode(op, node);

op = machine()->TruncateFloat64ToFloat32();

} else if (output_type & kRepFloat64) {

- op = machine()->ChangeFloat32ToFloat64();

+ op = machine()->TruncateFloat64ToFloat32();

} else {

return TypeError(node, output_type, kRepFloat32);

}

« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/simplified-lowering.h » ('j') | no next file with comments »