Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 640593006: Revert of [Mac] Enter should trigger the buttons in the new avatar bubble. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Enter should trigger the buttons in the new avatar bubble. (patchset #1 id:1 of https://codereview.chromium.org/644023002/) Reason for revert: This doesn't do what it's supposed to do, and after more discussions with groby@, Enter is really only used for default buttons on Mac, not all buttons. Original issue's description: > [Mac] Enter should trigger the buttons in the new avatar bubble. > > Only space seems to work by default. > > BUG=415823 > > Committed: https://crrev.com/9750bbaa9e0b3d0bbe44431216d570ecc789024f > Cr-Commit-Position: refs/heads/master@{#299157} TBR=groby@chromium.org NOTREECHECKS=true NOTRY=true BUG=415823 Committed: https://crrev.com/4530a109e1867a9662ea92a3048e3db5e02dbd60 Cr-Commit-Position: refs/heads/master@{#300175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noms (inactive)
Created Revert of [Mac] Enter should trigger the buttons in the new avatar bubble.
6 years, 2 months ago (2014-10-17 22:18:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640593006/1
6 years, 2 months ago (2014-10-17 22:21:09 UTC) #2
groby-ooo-7-16
lgtm
6 years, 2 months ago (2014-10-17 22:21:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 22:22:54 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:24:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4530a109e1867a9662ea92a3048e3db5e02dbd60
Cr-Commit-Position: refs/heads/master@{#300175}

Powered by Google App Engine
This is Rietveld 408576698