Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: net/test/embedded_test_server/http_request_unittest.cc

Issue 640593004: Fix a pair of Cronet upload bugs and add tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test, fix merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/net_error_list.h ('K') | « net/test/embedded_test_server/http_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/embedded_test_server/http_request_unittest.cc
diff --git a/net/test/embedded_test_server/http_request_unittest.cc b/net/test/embedded_test_server/http_request_unittest.cc
index b45742cf37b797e5fec09d6747042b2eb46cad30..1006e4ede90bfb66656cc319d3cebf0b93b8089d 100644
--- a/net/test/embedded_test_server/http_request_unittest.cc
+++ b/net/test/embedded_test_server/http_request_unittest.cc
@@ -35,6 +35,7 @@ TEST(HttpRequestTest, ParseRequest) {
{
scoped_ptr<HttpRequest> request = parser.GetRequest();
EXPECT_EQ("/foobar.html", request->relative_url);
+ EXPECT_EQ("POST", request->method_string);
EXPECT_EQ(METHOD_POST, request->method);
EXPECT_EQ("1234567890", request->content);
ASSERT_EQ(3u, request->headers.size());
@@ -78,5 +79,19 @@ TEST(HttpRequestTest, ParseRequestWithoutBody) {
EXPECT_FALSE(request->has_content);
}
+TEST(HttpRequestTest, ParseGet) {
+ HttpRequestParser parser;
+
+ parser.ProcessChunk("GET /foobar.html HTTP/1.1\r\n\r\n");
+ ASSERT_EQ(HttpRequestParser::ACCEPTED, parser.ParseRequest());
+
+ scoped_ptr<HttpRequest> request = parser.GetRequest();
+ EXPECT_EQ("/foobar.html", request->relative_url);
+ EXPECT_EQ("GET", request->method_string);
+ EXPECT_EQ(METHOD_GET, request->method);
+ EXPECT_EQ("", request->content);
+ EXPECT_FALSE(request->has_content);
+}
+
} // namespace test_server
} // namespace net
« net/base/net_error_list.h ('K') | « net/test/embedded_test_server/http_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698