components/cronet/android/wrapped_channel_upload_element_reader.cc - Issue 640593004: Fix a pair of Cronet upload bugs and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/wrapped_channel_upload_element_reader.cc

Issue 640593004: Fix a pair of Cronet upload bugs and add tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test, fix merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/wrapped_channel_upload_element_reader.cc

diff --git a/components/cronet/android/wrapped_channel_upload_element_reader.cc b/components/cronet/android/wrapped_channel_upload_element_reader.cc

index a4b0d0d3e70ed299a4898459c88e057b21b87f5c..750d382601bf25a3e09d5db2920febbb9245e69a 100644

--- a/components/cronet/android/wrapped_channel_upload_element_reader.cc

+++ b/components/cronet/android/wrapped_channel_upload_element_reader.cc

@@ -21,7 +21,8 @@ WrappedChannelElementReader::~WrappedChannelElementReader() {

}

int WrappedChannelElementReader::Init(const net::CompletionCallback& callback) {

- offset_ = 0;

+ if (offset_ != 0)

+ return net::ERR_UPLOAD_STREAM_REWIND_NOT_SUPPORTED;

return net::OK;

}