components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java - Issue 640593004: Fix a pair of Cronet upload bugs and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

Issue 640593004: Fix a pair of Cronet upload bugs and add tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test, fix merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/cronet_test_jni.cc ('k') | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/UploadTest.java » ('j') | net/base/net_error_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

index 4f9db10d776d90b476430c0676c8c174fd320775..2ff6464610be7e8357dca0be372d8ab4add2b62b 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

@@ -20,6 +20,7 @@ public class TestHttpUrlRequestListener implements HttpUrlRequestListener {

public int mHttpStatusCode = 0;

public String mUrl;

public byte[] mResponseAsBytes;

+ public String mResponseAsString;

public String mNegotiatedProtocol;

private ConditionVariable mComplete = new ConditionVariable();

@@ -40,6 +41,7 @@ public class TestHttpUrlRequestListener implements HttpUrlRequestListener {

public void onRequestComplete(HttpUrlRequest request) {

mUrl = request.getUrl();

mResponseAsBytes = request.getResponseAsBytes();

+ mResponseAsString = new String(mResponseAsBytes);

mComplete.open();

Log.i(TAG, "****** Request Complete, status code is " +

request.getHttpStatusCode());