Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

Issue 640593004: Fix a pair of Cronet upload bugs and add tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reorder fields Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
index 4f9db10d776d90b476430c0676c8c174fd320775..22429aeb706a00a1241f3fa01d4289b1b447a9d2 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
@@ -17,10 +17,14 @@ import org.chromium.net.HttpUrlRequestListener;
public class TestHttpUrlRequestListener implements HttpUrlRequestListener {
public static final String TAG = "TestHttpUrlRequestListener";
+
public int mHttpStatusCode = 0;
+ public String mNegotiatedProtocol;
+
public String mUrl;
public byte[] mResponseAsBytes;
- public String mNegotiatedProtocol;
+ public String mResponseAsString;
+ public Exception mException;
private ConditionVariable mComplete = new ConditionVariable();
@@ -40,6 +44,8 @@ public class TestHttpUrlRequestListener implements HttpUrlRequestListener {
public void onRequestComplete(HttpUrlRequest request) {
mUrl = request.getUrl();
mResponseAsBytes = request.getResponseAsBytes();
+ mResponseAsString = new String(mResponseAsBytes);
+ mException = request.getException();
mComplete.open();
Log.i(TAG, "****** Request Complete, status code is " +
request.getHttpStatusCode());

Powered by Google App Engine
This is Rietveld 408576698