Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 640453002: Increase coverage of telemetry's user_agent_unittest (Closed)

Created:
6 years, 2 months ago by Daniel Imms
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Increase coverage of telemetry's user_agent_unittest Added a mobile and desktop testing in case the browser being tested has a user agent that defaults to the tablet user agent. BUG=421229 Committed: https://crrev.com/63f233bcd3a8a6d7f3cfb5183b62160c96ded98e Cr-Commit-Position: refs/heads/master@{#300349}

Patch Set 1 #

Patch Set 2 : Adding myself to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/user_agent_unittest.py View 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
Daniel Imms
6 years, 2 months ago (2014-10-07 22:41:48 UTC) #2
tonyg
lgtm
6 years, 2 months ago (2014-10-14 21:13:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640453002/1
6 years, 2 months ago (2014-10-14 21:14:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17601)
6 years, 2 months ago (2014-10-14 21:25:37 UTC) #7
tonyg
daniimms@amazon.com is not in AUTHORS file. If you are a new contributor, please visit http://www.chromium.org/developers/contributing-code ...
6 years, 2 months ago (2014-10-14 21:30:58 UTC) #8
Daniel Imms
On 2014/10/14 21:30:58, tonyg wrote: > mailto:daniimms@amazon.com is not in AUTHORS file. If you are ...
6 years, 2 months ago (2014-10-14 21:50:33 UTC) #9
Daniel Imms
On 2014/10/14 21:50:33, Daniel imms wrote: > On 2014/10/14 21:30:58, tonyg wrote: > > mailto:daniimms@amazon.com ...
6 years, 2 months ago (2014-10-14 22:19:27 UTC) #10
Daniel Imms
6 years, 2 months ago (2014-10-16 21:39:01 UTC) #11
tonyg
lgtm
6 years, 2 months ago (2014-10-20 20:23:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640453002/20001
6 years, 2 months ago (2014-10-20 20:24:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 22:08:53 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:10:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63f233bcd3a8a6d7f3cfb5183b62160c96ded98e
Cr-Commit-Position: refs/heads/master@{#300349}

Powered by Google App Engine
This is Rietveld 408576698