Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 640423002: Uses stp/ldp for frame entry/exit on arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc (revision 41023)
+++ runtime/vm/assembler_arm64.cc (working copy)
@@ -1147,8 +1147,7 @@
void Assembler::EnterFrame(intptr_t frame_size) {
- Push(LR);
- Push(FP);
+ PushPair(LR, FP);
mov(FP, SP);
if (frame_size > 0) {
@@ -1159,8 +1158,7 @@
void Assembler::LeaveFrame() {
mov(SP, FP);
- Pop(FP);
- Pop(LR);
+ PopPair(LR, FP);
}
@@ -1168,8 +1166,7 @@
// Setup the frame.
adr(TMP, Immediate(-CodeSize())); // TMP gets PC marker.
EnterFrame(0);
- Push(TMP); // Save PC Marker.
- TagAndPushPP(); // Save PP.
+ TagAndPushPPAndPcMarker(TMP); // Save PP and PC marker.
// Load the pool pointer.
LoadPoolPointer(PP);
@@ -1185,8 +1182,7 @@
// Setup the frame.
adr(TMP, Immediate(-CodeSize())); // TMP gets PC marker.
EnterFrame(0);
- Push(TMP); // Save PC Marker.
- TagAndPushPP(); // Save PP.
+ TagAndPushPPAndPcMarker(TMP); // Save PP and PC marker.
// Load the pool pointer.
if (new_pp == kNoPP) {
@@ -1283,8 +1279,7 @@
PopDouble(reg);
}
- Pop(FP);
- Pop(LR);
+ PopPair(LR, FP);
}
@@ -1296,8 +1291,8 @@
void Assembler::EnterStubFrame(bool load_pp) {
EnterFrame(0);
- Push(ZR); // Push 0 in the saved PC area for stub frames.
- TagAndPushPP(); // Save caller's pool pointer
+ // Save caller's pool pointer. Push 0 in the saved PC area for stub frames.
+ TagAndPushPPAndPcMarker(ZR);
if (load_pp) {
LoadPoolPointer(PP);
}
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698