Issue 640413004: Revert of Fix color emoji.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 640413004: Revert of Fix color emoji. (Closed)

Created:
6 years, 2 months ago by jvanverth1

Modified:
6 years, 2 months ago

Reviewers:
bungeman-skia, bsalomon, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix color emoji. (patchset #11 id:320001 of https://codereview.chromium.org/636183005/) Reason for revert: Crashing the Windows bots. Original issue's description: > Fix color emoji. > > Removes the GrMaskFormat and single atlas in GrTextStrike. > Replaces it by storing the GrMaskFormat in each GrGlyph, and > doing a lookup for the correct atlas based on that. > > Disables color glyph rendering in GrDistanceFieldTextContext > for now. > > BUG=skia:2887 > > Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216 TBR=robertphillips@google.com,bungeman@google.com,reed@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2887 Committed: https://skia.googlesource.com/skia/+/e817dbb889b6ef1a811c2c3e6b405ad5c11d6758

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -126 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	include/gpu/GrFontScaler.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	include/gpu/GrGlyph.h	View	2 chunks	+7 lines, -11 lines	0 comments	Download
M	src/gpu/GrBitmapTextContext.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/gpu/GrBitmapTextContext.cpp	View	6 chunks	+8 lines, -10 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.cpp	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	src/gpu/GrFontScaler.cpp	View	2 chunks	+1 line, -23 lines	0 comments	Download
M	src/gpu/GrTextStrike.h	View	3 chunks	+8 lines, -9 lines	0 comments	Download
M	src/gpu/GrTextStrike.cpp	View	7 chunks	+59 lines, -56 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640413004/1

6 years, 2 months ago (2014-10-10 15:51:44 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-10 15:52:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as e817dbb889b6ef1a811c2c3e6b405ad5c11d6758