Drop refs to net::EmbeddedTestServer / net::File{Path,URL} utils in mojo

Drop refs to net::EmbeddedTestServer / net::File{Path,URL} utils in mojo

We don't actually use the embedded test server and we don't need most
of what the file path conversion utilities provide. We only need to
support very simple URLs for loading off of file paths and we do not
need to support windows at all for mojo_shell.

Committed: https://crrev.com/b7893322082382329bf46d20d91c4695c234026c
Cr-Commit-Position: refs/heads/master@{#300331}

[jamesr, 2014-10-09 20:09:58]

jamesr@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2014-10-09 22:26:29]

https://codereview.chromium.org/640403002/diff/1/mojo/shell/dynamic_applicati...
File mojo/shell/dynamic_application_loader.cc (right):

https://codereview.chromium.org/640403002/diff/1/mojo/shell/dynamic_applicati...
mojo/shell/dynamic_application_loader.cc:98: base::FilePath
path(base::ASCIIToUTF16(url.path()));
This isn't correct, the path on Windows will be "/C:/foo/bar". You'll want the
logic from FileURLToFilePath (maybe don't need the UNC stuff) that trims the
leading slash and replaces the forward slashes with backslashes. You could also
call FilePath.NormalizePathSeparators().

We also really need to unescape in both cases since we should be able to run in
non-ASCII directories. On Windows, this means doing UTF-8 -> UTF-16 conversion
after unescaping.

And I think this should be moved to the new file with a test like the reverse
conversion.

[jamesr, 2014-10-09 22:35:56]

On 2014/10/09 22:26:29, brettw wrote:
>
https://codereview.chromium.org/640403002/diff/1/mojo/shell/dynamic_applicati...
> File mojo/shell/dynamic_application_loader.cc (right):
> 
>
https://codereview.chromium.org/640403002/diff/1/mojo/shell/dynamic_applicati...
> mojo/shell/dynamic_application_loader.cc:98: base::FilePath
> path(base::ASCIIToUTF16(url.path()));
> This isn't correct, the path on Windows will be "/C:/foo/bar". You'll want the
> logic from FileURLToFilePath (maybe don't need the UNC stuff) that trims the
> leading slash and replaces the forward slashes with backslashes. You could
also
> call FilePath.NormalizePathSeparators().

I don't care about this code running on windows.

[jamesr, 2014-10-09 22:38:05]

I could add a #if defined(OS_WINDOWS) NOTREACHED() if you'd prefer.

[brettw, 2014-10-09 22:44:07]

It needs to be unescaped in any case.

I think the shell should be runnable on Windows, and two obvious lines here
shouldn't be the reason it won't I was debugging on Windows last week.

[jamesr, 2014-10-16 21:41:37]

https://codereview.chromium.org/640403002/diff/260001/mojo/shell/dynamic_appl...
File mojo/shell/dynamic_application_loader.cc (right):

https://codereview.chromium.org/640403002/diff/260001/mojo/shell/dynamic_appl...
mojo/shell/dynamic_application_loader.cc:99: url::DecodeURLEscapeSequences(
PTAL

[jamesr, 2014-10-20 17:16:47]

ping

[brettw, 2014-10-20 17:26:37]

lgtm

https://codereview.chromium.org/640403002/diff/260001/mojo/shell/filename_uti...
File mojo/shell/filename_util.cc (right):

https://codereview.chromium.org/640403002/diff/260001/mojo/shell/filename_uti...
mojo/shell/filename_util.cc:18: FILE_PATH_LITERAL("file:///");
You wan only two slashes here since you're appending the path (which has a slash
at the beginning).

https://codereview.chromium.org/640403002/diff/260001/mojo/shell/filename_uti...
mojo/shell/filename_util.cc:37: // must be the first substitution since others
will introduce percents as the
Should be a complete sentence.

[jamesr, 2014-10-20 17:35:30]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-10-20 17:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640403002/280001

[commit-bot: I haz the power, 2014-10-20 17:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 17:40:19]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/70780)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jamesr, 2014-10-20 18:19:24]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-10-20 18:20:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640403002/300001

[commit-bot: I haz the power, 2014-10-20 19:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 19:11:10]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jamesr, 2014-10-20 19:19:23]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-10-20 19:22:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640403002/320001

[commit-bot: I haz the power, 2014-10-20 20:56:37]

Committed patchset #5 (id:320001)

[commit-bot: I haz the power, 2014-10-20 20:57:19]

Patchset 5 (id:??) landed as
https://crrev.com/b7893322082382329bf46d20d91c4695c234026c
Cr-Commit-Position: refs/heads/master@{#300331}