Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: util/mac/process_reader_test.cc

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mac/mach_o_image_reader_test.cc ('k') | util/mach/mach_message_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/process_reader_test.cc
diff --git a/util/mac/process_reader_test.cc b/util/mac/process_reader_test.cc
index e67c98e8de65205d528e47966d9ab2f501504c03..d1e47cd60433f37298cb658a5c3d686c2d26a512 100644
--- a/util/mac/process_reader_test.cc
+++ b/util/mac/process_reader_test.cc
@@ -370,10 +370,7 @@ TEST(ProcessReader, SelfSeveralThreads) {
TestThreadPool thread_pool;
const size_t kChildThreads = 16;
- thread_pool.StartThreads(kChildThreads);
- if (Test::HasFatalFailure()) {
- return;
- }
+ ASSERT_NO_FATAL_FAILURE(thread_pool.StartThreads(kChildThreads));
// Build a map of all expected threads, keyed by each thread’s ID. The values
// are addresses that should lie somewhere within each thread’s stack.
@@ -462,10 +459,7 @@ class ProcessReaderThreadedChild final : public MachMultiprocess {
void MachMultiprocessChild() override {
TestThreadPool thread_pool;
- thread_pool.StartThreads(thread_count_);
- if (testing::Test::HasFatalFailure()) {
- return;
- }
+ ASSERT_NO_FATAL_FAILURE(thread_pool.StartThreads(thread_count_));
int write_fd = WritePipeFD();
« no previous file with comments | « util/mac/mach_o_image_reader_test.cc ('k') | util/mach/mach_message_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698