Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 640373006: Don't use 64KB of stack on a single call. (Closed)

Created:
6 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 2 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Don't use 64KB of stack on a single call. Stacks grow slowly (via page faults) and never shrink. TBR=rvargas BUG=none Committed: https://crrev.com/9deb57578a2888afe8a99420e74c00d1e0a5b100 Cr-Commit-Position: refs/heads/master@{#300395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/files/file_util.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cpu_(ooo_6.6-7.5)
ptal
6 years, 2 months ago (2014-10-17 22:33:12 UTC) #2
grt (UTC plus 2)
lgtm. nice catch.
6 years, 2 months ago (2014-10-18 02:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640373006/1
6 years, 2 months ago (2014-10-20 19:12:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18722)
6 years, 2 months ago (2014-10-20 19:23:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640373006/1
6 years, 2 months ago (2014-10-21 01:14:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 01:21:06 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 01:21:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9deb57578a2888afe8a99420e74c00d1e0a5b100
Cr-Commit-Position: refs/heads/master@{#300395}

Powered by Google App Engine
This is Rietveld 408576698