Issue 640373003: util_test Clock.SleepNanoseconds: don’t set an upper bound for the amount of time spent sleeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 640373003: util_test Clock.SleepNanoseconds: don’t set an upper bound for the amount of time spent sleeping (Closed)

Created:
6 years, 2 months ago by Mark Mentovai

Modified:
6 years, 2 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

util_test Clock.SleepNanoseconds: don’t set an upper bound for the amount of time spent sleeping. Even with the slop, this wound up being flaky, specifically on virtual machines. And guess what our automated test infrastructure runs on? TEST=util_test Clock.SleepNanoseconds R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8f23d3e475e736af68333d95ff78c48cc6c4d80c

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	util/misc/clock_test.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 2 months ago (2014-10-10 18:01:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8f23d3e475e736af68333d95ff78c48cc6c4d80c (presubmit successful).