Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 640353004: Oilpan: Fix threading races on ThreadState::s_mainThreadStackStart (Closed)

Created:
6 years, 1 month ago by haraken
Modified:
6 years, 1 month ago
Reviewers:
oilpan-reviews, tkent
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: Fix threading races on ThreadState::s_mainThreadStackStart I forgot to add a isMainThread() check to ~ThreadState(). This CL just adds the check. BUG=427657 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/platform/heap/ThreadState.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
PTAL
6 years, 1 month ago (2014-10-28 00:50:05 UTC) #2
tkent
lgtm
6 years, 1 month ago (2014-10-28 01:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640353004/1
6 years, 1 month ago (2014-10-28 01:03:05 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 02:46:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184492

Powered by Google App Engine
This is Rietveld 408576698