Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 640323004: Telemetry: Don't use the full path to rdmsr on Linux. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Don't use the full path to rdmsr on Linux. This fixes the bots, even though when I log into the bots and run rdmsr with the full path through Python, it works fine. This should be ok, since Ubuntu includes the sbin directories in the path by default. BUG=336556 Committed: https://crrev.com/d0c9db15b39f1f50c92ed395a3a9677811864b0a Cr-Commit-Position: refs/heads/master@{#299019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
I don't fully understand why this doesn't work as is, but this is the workaround.
6 years, 2 months ago (2014-10-09 20:26:18 UTC) #2
tonyg
lgtm
6 years, 2 months ago (2014-10-09 20:34:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640323004/1
6 years, 2 months ago (2014-10-09 20:37:46 UTC) #6
dtu
lgtm
6 years, 2 months ago (2014-10-09 20:42:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 00:16:14 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:17:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0c9db15b39f1f50c92ed395a3a9677811864b0a
Cr-Commit-Position: refs/heads/master@{#299019}

Powered by Google App Engine
This is Rietveld 408576698