Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: Source/core/page/DragState.h

Issue 640303002: Enable Oilpan for core/clipboard/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased and updated Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/DragState.h
diff --git a/Source/core/page/DragState.h b/Source/core/page/DragState.h
index 3248cc3290f7b9379b8365e032ff4f55a27e2775..9a5ac3b130fef2394a870ed5e73f0ef821118367 100644
--- a/Source/core/page/DragState.h
+++ b/Source/core/page/DragState.h
@@ -27,6 +27,7 @@
#define DragState_h
#include "core/page/DragActions.h"
+#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
#include "wtf/RefPtr.h"
@@ -35,18 +36,20 @@ namespace blink {
class DataTransfer;
class Node;
-class DragState : public NoBaseWillBeGarbageCollected<DragState> {
+class DragState final : public GarbageCollectedFinalized<DragState> {
haraken 2015/04/23 04:47:08 Does this need to be Finalized?
sof 2015/04/23 08:01:53 Has a RefPtr<> non-Oilpan; I added a TODO(Oilpan)
WTF_MAKE_NONCOPYABLE(DragState);
public:
DragState() { }
RefPtrWillBeMember<Node> m_dragSrc; // element that may be a drag source, for the current mouse gesture
DragSourceAction m_dragType;
- RefPtrWillBeMember<DataTransfer> m_dragDataTransfer; // used on only the source side of dragging
+ Member<DataTransfer> m_dragDataTransfer; // used on only the source side of dragging
DEFINE_INLINE_TRACE()
{
+#if ENABLE(OILPAN)
haraken 2015/04/23 04:47:08 This wouldn't be needed.
sof 2015/04/23 08:01:53 Gone now.
visitor->trace(m_dragSrc);
+#endif
visitor->trace(m_dragDataTransfer);
}
};

Powered by Google App Engine
This is Rietveld 408576698