Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640303002: Enable Oilpan for core/clipboard/ (Closed)

Created:
6 years, 2 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, jamesr, arv+blink, tzik, eae+blinkwatch, dcheng, mkwst+moarreviews_chromium.org, nhiroki, blink-reviews-events_chromium.org, dglazkov+blink, Inactive, kinuko+fileapi, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable Oilpan for core/clipboard/ Enable Oilpan by default for the DataTransfer* and DataObject* interface objects. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194347

Patch Set 1 #

Patch Set 2 : Make DragState a GCed object always #

Patch Set 3 : rebased and updated #

Total comments: 9

Patch Set 4 : remove some slightly pointy edges #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -165 lines) Patch
M Source/core/clipboard/DataObject.h View 1 2 3 3 chunks +13 lines, -14 lines 0 comments Download
M Source/core/clipboard/DataObject.cpp View 1 2 12 chunks +20 lines, -22 lines 0 comments Download
M Source/core/clipboard/DataObjectItem.h View 1 2 2 chunks +9 lines, -11 lines 0 comments Download
M Source/core/clipboard/DataObjectItem.cpp View 1 2 1 chunk +18 lines, -18 lines 0 comments Download
M Source/core/clipboard/DataObjectTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/clipboard/DataTransfer.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/clipboard/DataTransfer.cpp View 1 2 4 chunks +7 lines, -5 lines 0 comments Download
M Source/core/clipboard/DataTransfer.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/DataTransferItem.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/clipboard/DataTransferItem.cpp View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/clipboard/DataTransferItem.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/DataTransferItemList.h View 1 2 1 chunk +8 lines, -9 lines 0 comments Download
M Source/core/clipboard/DataTransferItemList.cpp View 1 2 4 chunks +9 lines, -11 lines 0 comments Download
M Source/core/clipboard/DataTransferItemList.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/Pasteboard.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/Pasteboard.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/events/ClipboardEvent.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/ClipboardEvent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/MouseEvent.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/FileInputTypeTest.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/DragData.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/DragState.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DataTransferItemFileSystem.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DraggedIsolatedFileSystemImpl.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp View 1 2 3 chunks +4 lines, -8 lines 0 comments Download
M Source/web/WebDragDataTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
sof
Please take a look. Low priority, just readying the changed reqd to eventually ship.
6 years, 2 months ago (2014-10-09 20:06:06 UTC) #2
haraken
Sorry for letting you work on this. As discussed in blink-dev@, we won't ship Oilpan ...
6 years, 2 months ago (2014-10-09 23:20:33 UTC) #3
sof
On 2014/10/09 23:20:33, haraken wrote: > Sorry for letting you work on this. > > ...
6 years, 2 months ago (2014-10-10 05:37:36 UTC) #4
sof
please take a look. https://codereview.chromium.org/640303002/diff/100001/Source/core/clipboard/DataObject.h File Source/core/clipboard/DataObject.h (right): https://codereview.chromium.org/640303002/diff/100001/Source/core/clipboard/DataObject.h#newcode54 Source/core/clipboard/DataObject.h:54: class DataObject : public GarbageCollectedFinalized<DataObject>, ...
5 years, 8 months ago (2015-04-22 21:48:11 UTC) #5
haraken
LGTM https://codereview.chromium.org/640303002/diff/100001/Source/core/clipboard/DataObject.h File Source/core/clipboard/DataObject.h (right): https://codereview.chromium.org/640303002/diff/100001/Source/core/clipboard/DataObject.h#newcode61 Source/core/clipboard/DataObject.h:61: DataObject* copy() const; What is this for? https://codereview.chromium.org/640303002/diff/100001/Source/core/page/DragState.h ...
5 years, 8 months ago (2015-04-23 04:47:08 UTC) #7
sof
https://codereview.chromium.org/640303002/diff/100001/Source/core/clipboard/DataObject.h File Source/core/clipboard/DataObject.h (right): https://codereview.chromium.org/640303002/diff/100001/Source/core/clipboard/DataObject.h#newcode54 Source/core/clipboard/DataObject.h:54: class DataObject : public GarbageCollectedFinalized<DataObject>, public HeapSupplementable<DataObject> { On ...
5 years, 8 months ago (2015-04-23 08:01:53 UTC) #8
sof
Will await Oilpan trybot results, but ok to proceed & make Oilpan enabled by default ...
5 years, 8 months ago (2015-04-23 11:39:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640303002/120001
5 years, 8 months ago (2015-04-24 05:21:03 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 05:25:32 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194347

Powered by Google App Engine
This is Rietveld 408576698