Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 640293005: Revert of Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel, lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests_other0
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView. (patchset #4 id:60001 of https://codereview.chromium.org/642573002/) Reason for revert: Speculative revert for double frees on mac gpu bots. http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/56935 http://build.chromium.org/p/chromium.gpu/builders/Mac%20Debug%20%28Intel%29/builds/38058 Original issue's description: > Remove the RenderProcessHost observer and attach the WebContentsObserver earlier to the GuestView. > > This fixes an issue where if the embedder WebContents is destroyed during a GuestView creation we may end up leaking the guest WebContents. > > BUG=419020 > > Committed: https://crrev.com/52fce9455ffd688ef3752a816192f9e76555e7d1 > Cr-Commit-Position: refs/heads/master@{#298934} TBR=fsamuel@chromium.org,lfg@chromium.org NOTREECHECKS=true NOTRY=true BUG=419020 Committed: https://crrev.com/08b3992fde2ac62aa98ec0d35e05ce8562288bcc Cr-Commit-Position: refs/heads/master@{#298974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -42 lines) Patch
M extensions/browser/guest_view/guest_view_base.h View 5 chunks +14 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 8 chunks +44 lines, -31 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/guest_view_manager.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
danakj
6 years, 2 months ago (2014-10-09 20:38:50 UTC) #1
Created Revert of Remove the RenderProcessHost observer and attach the
WebContentsObserver earlier to the GuestView.

Powered by Google App Engine
This is Rietveld 408576698