[WebGL-blink] Return meaningful information in WebGL context creation error message

[WebGL] Return meaningful information in WebGL context creation error message.
For example, vendor, renderer, driver version, etc.This
way a developer can gather data on what platforms the app 
fails to run. This needs changes on both blink and chromium.

Below steps are followed to implement this

1. Add basic headers in blink.
2. Add the necessary apis in chromium.
3. Start using this in WebglRenderingContxt.cpp.

This patch represents step-1 in this process.

BUG=412440
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184620

[sivag, 2014-10-10 14:15:11]

siva.gunturi@samsung.com changed reviewers:
+ kbr@chromium.org, tkent@chromium.org

[sivag, 2014-10-10 14:15:11]

kbr ,tkent
ptal
connecting chrome patch https://codereview.chromium.org/645613002/

[piman, 2014-10-10 20:23:06]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2014-10-10 20:23:06]

https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform...
public/platform/Platform.h:560: virtual WebGraphicsContext3D*
createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&,
WebGraphicsContext3D* shareContext, WebGLInfo& glInfo) { return 0; }
Please pass output params by pointer, not (non-const) references.

[Ken Russell (switch to Gerrit), 2014-10-10 20:47:38]

https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform...
public/platform/Platform.h:560: virtual WebGraphicsContext3D*
createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&,
WebGraphicsContext3D* shareContext, WebGLInfo& glInfo) { return 0; }
Also, figure out a way to avoid temporarily breaking the override in Chromium,
whether this means temporarily overriding both the old and new signature in
Chromium, or temporarily having both signatures as virtual in Blink and having
the new one temporarily delegate to the old one.

[sivag, 2014-10-27 13:33:52]

PTAL..

https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform...
public/platform/Platform.h:560: virtual WebGraphicsContext3D*
createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&,
WebGraphicsContext3D* shareContext, WebGLInfo& glInfo) { return 0; }
On 2014/10/10 20:23:06, piman (Very slow to review) wrote:
> Please pass output params by pointer, not (non-const) references.

Done.

[sivag, 2014-10-29 17:35:08]

ptal..
@kbr how to land this patch along with
https://codereview.chromium.org/645613002/, 
i think the headers should go first please suggest.

[sivag, 2014-10-29 19:13:44]

On 2014/10/10 20:47:38, Ken Russell wrote:
>
https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform.h
> File public/platform/Platform.h (right):
> 
>
https://codereview.chromium.org/640293002/diff/20001/public/platform/Platform...
> public/platform/Platform.h:560: virtual WebGraphicsContext3D*
> createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&,
> WebGraphicsContext3D* shareContext, WebGLInfo& glInfo) { return 0; }
> Also, figure out a way to avoid temporarily breaking the override in Chromium,
> whether this means temporarily overriding both the old and new signature in
> Chromium, or temporarily having both signatures as virtual in Blink and having
> the new one temporarily delegate to the old one.

ptal, with these changes chromium patch should get landed.
once this lands i will enable the webglrenderingcontext , status
message changes.

[Ken Russell (switch to Gerrit), 2014-10-29 21:32:19]

lgtm

[sivag, 2014-10-30 02:25:45]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2014-10-30 02:25:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640293002/140001

[commit-bot: I haz the power, 2014-10-30 02:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 02:32:46]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[Ken Russell (switch to Gerrit), 2014-10-30 02:42:47]

kbr@chromium.org changed reviewers:
+ darin@chromium.org, dglazkov@chromium.org, japhet@chromium.org,
pfeldman@chromium.org

[Ken Russell (switch to Gerrit), 2014-10-30 02:42:48]

+more public/ OWNERS. OWNERS review please. Thanks.

[dglazkov, 2014-10-30 02:55:50]

On 2014/10/30 02:42:48, Ken Russell wrote:
> +more public/ OWNERS. OWNERS review please. Thanks.

LGTM, but please add more context to description. It is unclear what you're
doing here and it takes digging through comments to realize that you're plumbing
through a replacement API. Typically, these changes have a "Step 1 of N" line
somewhere with the entire set of steps laid out in description.

[sivag, 2014-10-30 06:29:40]

On 2014/10/30 02:55:50, dglazkov wrote:
> On 2014/10/30 02:42:48, Ken Russell wrote:
> > +more public/ OWNERS. OWNERS review please. Thanks.
> 
> LGTM, but please add more context to description. It is unclear what you're
> doing here and it takes digging through comments to realize that you're
plumbing
> through a replacement API. Typically, these changes have a "Step 1 of N" line
> somewhere with the entire set of steps laid out in description.

Done, Thanks.

[sivag, 2014-10-30 06:29:48]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2014-10-30 06:30:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640293002/140001

[commit-bot: I haz the power, 2014-10-30 06:35:26]

Committed patchset #5 (id:140001) as 184620