Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 640253007: Adds additional fields to web::NavigationItem. (Closed)

Created:
6 years, 2 months ago by rohitrao (ping after 24h)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Adds additional fields to web::NavigationItem. This CL also adds the web::FaviconStatus and web::SSLStatus structs. These are //web analogues of the //content structs of the same name. BUG=422033, 423031 TEST=None Committed: https://crrev.com/c2cefa41030c3865b7a6e5b52776aea90be8d92d Cr-Commit-Position: refs/heads/master@{#300138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -22 lines) Patch
M ios/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
A + ios/web/public/favicon_status.h View 2 chunks +8 lines, -9 lines 0 comments Download
A ios/web/public/favicon_status.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ios/web/public/navigation_item.h View 2 chunks +65 lines, -3 lines 0 comments Download
A + ios/web/public/security_style.h View 2 chunks +6 lines, -6 lines 0 comments Download
A ios/web/public/ssl_status.h View 1 chunk +49 lines, -0 lines 0 comments Download
A + ios/web/public/ssl_status.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rohitrao (ping after 24h)
It's time!
6 years, 2 months ago (2014-10-17 16:07:37 UTC) #2
stuartmorgan
LGTM
6 years, 2 months ago (2014-10-17 17:58:19 UTC) #3
rohitrao (ping after 24h)
+asanka for OWNERS approval of the new entry in ios/web/DEPS. For background, ios/web is the ...
6 years, 2 months ago (2014-10-17 17:59:03 UTC) #6
asanka
lgtm
6 years, 2 months ago (2014-10-17 18:56:21 UTC) #7
rohitrao (ping after 24h)
Thanks for the reviews!
6 years, 2 months ago (2014-10-17 18:58:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640253007/1
6 years, 2 months ago (2014-10-17 19:00:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 19:05:30 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 19:06:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2cefa41030c3865b7a6e5b52776aea90be8d92d
Cr-Commit-Position: refs/heads/master@{#300138}

Powered by Google App Engine
This is Rietveld 408576698