Files.app: Make DialogFooter UI class.

Files.app: Make DialogFooter UI class.

BUG=267281
TEST=None

Committed: https://crrev.com/d01014df840e0a6bd4370d2caf7fd54c4aa68346
Cr-Commit-Position: refs/heads/master@{#300647}

[hirono, 2014-10-21 06:47:45]

hirono@chromium.org changed reviewers:
+ fukino@chromium.org

[hirono, 2014-10-21 06:47:45]

hirono@chromium.org changed reviewers:
+ fukino@chromium.org

[hirono, 2014-10-21 06:47:45]

PTAL the CL? Thank you!

[hirono, 2014-10-21 06:47:45]

PTAL the CL? Thank you!

[fukino, 2014-10-21 08:17:05]

Thanks!

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js (right):

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:10: * @param
{Element} container Container of the dialog footer.
{!Element} for asserting the element exists looks better to me.

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:16: * @type
{string}
{DialogType} looks better

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:59: * @param
{Document} document Document.
{!Document} looks better, and please add @return

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:73: * @param
{string} dialogType Dialog type.
ditto (string->DialogType)

[hirono, 2014-10-22 03:49:30]

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js (right):

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:10: * @param
{Element} container Container of the dialog footer.
On 2014/10/21 08:17:05, fukino wrote:
> {!Element} for asserting the element exists looks better to me.

Done.

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:16: * @type
{string}
On 2014/10/21 08:17:05, fukino wrote:
> {DialogType} looks better

Done.

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:59: * @param
{Document} document Document.
On 2014/10/21 08:17:05, fukino wrote:
> {!Document} looks better, and please add @return

Done.

https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:73: * @param
{string} dialogType Dialog type.
On 2014/10/21 08:17:05, fukino wrote:
> ditto (string->DialogType)

Done.

[fukino, 2014-10-22 04:01:03]

On 2014/10/22 03:49:30, hirono wrote:
>
https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js (right):
> 
>
https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:10: * @param
> {Element} container Container of the dialog footer.
> On 2014/10/21 08:17:05, fukino wrote:
> > {!Element} for asserting the element exists looks better to me.
> 
> Done.
> 
>
https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:16: * @type
> {string}
> On 2014/10/21 08:17:05, fukino wrote:
> > {DialogType} looks better
> 
> Done.
> 
>
https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:59: * @param
> {Document} document Document.
> On 2014/10/21 08:17:05, fukino wrote:
> > {!Document} looks better, and please add @return
> 
> Done.
> 
>
https://codereview.chromium.org/640223006/diff/40001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js:73: * @param
> {string} dialogType Dialog type.
> On 2014/10/21 08:17:05, fukino wrote:
> > ditto (string->DialogType)
> 
> Done.

lgtm. Thanks!

[hirono, 2014-10-22 04:02:28]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-10-22 04:03:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640223006/60001

[commit-bot: I haz the power, 2014-10-22 04:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 04:06:35]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71823)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hirono, 2014-10-22 06:15:09]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-10-22 06:15:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640223006/60001

[commit-bot: I haz the power, 2014-10-22 06:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 06:18:30]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71856)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hirono, 2014-10-22 06:22:55]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-10-22 06:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640223006/80001

[commit-bot: I haz the power, 2014-10-22 08:05:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-22 08:06:32]

Patchset 5 (id:??) landed as
https://crrev.com/d01014df840e0a6bd4370d2caf7fd54c4aa68346
Cr-Commit-Position: refs/heads/master@{#300647}