RPHI::AddRoute: Turn a DCHECK() to a CHECK() again.

content/browser/renderer_host/render_process_host_impl.cc

Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index cbfa1504dcc45c3da2c9ca022ee9573df0cdd2de..2da21355fcd06a4bd9d2c981a1478b0f3ffa7bf4 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -921,8 +921,8 @@ ServiceRegistry* RenderProcessHostImpl::GetServiceRegistry() {
 void RenderProcessHostImpl::AddRoute(
     int32 routing_id,
     IPC::Listener* listener) {
-  DCHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id))
-      << "Found Routing ID conflicts: " << routing_id;
+  CHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id))
+      << "Found Invalid Routing ID: " << routing_id;

[nasko, 2014/10/16 20:08:57]

Why not add the check for duplicate? If we believe that we've found the root
cause and fixed it, it should never trigger, right?

   listeners_.AddWithID(listener, routing_id);
 }