cc/trees/layer_tree_host_pixeltest_filters.cc - Issue 640203002: [C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr [part-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_pixeltest_filters.cc

Issue 640203002: [C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr [part-… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_pixeltest_filters.cc

diff --git a/cc/trees/layer_tree_host_pixeltest_filters.cc b/cc/trees/layer_tree_host_pixeltest_filters.cc

index 4afc4eccf6a98e954a20b8cac88afdcc43958ea5..1098ed2b214f14ce47aaabf0d889bfea356a66e5 100644

--- a/cc/trees/layer_tree_host_pixeltest_filters.cc

+++ b/cc/trees/layer_tree_host_pixeltest_filters.cc

@@ -254,7 +254,7 @@ class ImageFilterClippedPixelTest : public LayerTreeHostFiltersPixelTest {

// We filter only the bottom 200x100 pixels of the foreground.

SkImageFilter::CropRect crop_rect(SkRect::MakeXYWH(0, 100, 200, 100));

skia::RefPtr<SkImageFilter> filter = skia::AdoptRef(

- SkColorFilterImageFilter::Create(colorFilter.get(), NULL, &crop_rect));

+ SkColorFilterImageFilter::Create(colorFilter.get(), nullptr, &crop_rect));

danakj 2014/10/09 16:00:53 and here

FilterOperations filters;

filters.Append(FilterOperation::CreateReferenceFilter(filter));

« cc/trees/layer_tree_host_impl.cc ('K') | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_host_unittest.cc » ('j') | cc/trees/layer_tree_host_unittest.cc » ('J')