Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: cc/trees/layer_tree_host_common_unittest.cc

Issue 640203002: [C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr [part-… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_common_unittest.cc
diff --git a/cc/trees/layer_tree_host_common_unittest.cc b/cc/trees/layer_tree_host_common_unittest.cc
index 9efcaea63ac3354ee8ca15c1e84dec869a848f8b..6f0ea668136161ad693e66e682016c13a730248e 100644
--- a/cc/trees/layer_tree_host_common_unittest.cc
+++ b/cc/trees/layer_tree_host_common_unittest.cc
@@ -5721,7 +5721,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
// Case 1: Identity transform.
gfx::Transform identity_matrix;
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
@@ -5731,7 +5731,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
integral_translation.Translate(1.0, 2.0);
child_->SetTransform(integral_translation);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
@@ -5741,7 +5741,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
non_integral_translation.Translate(1.5, 2.5);
child_->SetTransform(non_integral_translation);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_FALSE(child_->can_use_lcd_text());
EXPECT_FALSE(grand_child_->can_use_lcd_text());
@@ -5751,7 +5751,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
rotation.Rotate(10.0);
child_->SetTransform(rotation);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_FALSE(child_->can_use_lcd_text());
EXPECT_FALSE(grand_child_->can_use_lcd_text());
@@ -5761,7 +5761,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
scale.Scale(2.0, 2.0);
child_->SetTransform(scale);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_FALSE(child_->can_use_lcd_text());
EXPECT_FALSE(grand_child_->can_use_lcd_text());
@@ -5771,7 +5771,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
skew.SkewX(10.0);
child_->SetTransform(skew);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_FALSE(child_->can_use_lcd_text());
EXPECT_FALSE(grand_child_->can_use_lcd_text());
@@ -5780,7 +5780,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
child_->SetTransform(identity_matrix);
child_->SetOpacity(0.5f);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_FALSE(child_->can_use_lcd_text());
EXPECT_FALSE(grand_child_->can_use_lcd_text());
@@ -5789,7 +5789,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
child_->SetTransform(identity_matrix);
child_->SetOpacity(1.f);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
@@ -5798,7 +5798,7 @@ TEST_P(LCDTextTest, CanUseLCDText) {
TEST_P(LCDTextTest, CanUseLCDTextWithAnimation) {
// Sanity check: Make sure can_use_lcd_text_ is set on each node.
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, child_->can_use_lcd_text());
EXPECT_EQ(can_use_lcd_text_, grand_child_->can_use_lcd_text());
@@ -5809,7 +5809,7 @@ TEST_P(LCDTextTest, CanUseLCDTextWithAnimation) {
child_->layer_animation_controller(), 10.0, 0.9f, 0.1f, false);
ExecuteCalculateDrawProperties(
- root_.get(), 1.f, 1.f, NULL, can_use_lcd_text_);
+ root_.get(), 1.f, 1.f, nullptr, can_use_lcd_text_);
// Text AA should not be adjusted while animation is active.
// Make sure LCD text AA setting remains unchanged.
EXPECT_EQ(can_use_lcd_text_, root_->can_use_lcd_text());
@@ -8603,7 +8603,7 @@ TEST_F(LayerTreeHostCommonTest, VisibleContentRectInChildRenderSurface) {
host->root_layer(), device_viewport_size, &render_surface_layer_list);
inputs.device_scale_factor = 2.f;
inputs.page_scale_factor = 1.f;
- inputs.page_scale_application_layer = NULL;
+ inputs.page_scale_application_layer = nullptr;
LayerTreeHostCommon::CalculateDrawProperties(&inputs);
// Layers in the root render surface have their visible content rect clipped

Powered by Google App Engine
This is Rietveld 408576698