test/mjsunit/parse-surrogates.js - Issue 640193002: Allow identifier code points from supplementary multilingual planes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/parse-surrogates.js

Issue 640193002: Allow identifier code points from supplementary multilingual planes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: parser fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/parse-surrogates.js

diff --git a/test/mjsunit/es6/regress/regress-crbug-346141.js b/test/mjsunit/parse-surrogates.js

similarity index 52%

copy from test/mjsunit/es6/regress/regress-crbug-346141.js

copy to test/mjsunit/parse-surrogates.js

index 2b9655e174459088401996b884c4a5d7e02eb919..5ed9b524ce2e0510ce67a8ea74dbc7eb2c77f1a1 100644

--- a/test/mjsunit/es6/regress/regress-crbug-346141.js

+++ b/test/mjsunit/parse-surrogates.js

@@ -2,8 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-var s = Symbol()

-var o = {}

-o[s] = 2

-o[""] = 3

-Object.getOwnPropertySymbols(o)

+// Test that the parser throws on unmatched surrogates.

+assertThrows("var \uD801\uABCD;", SyntaxError);

+assertThrows("'\\u000\uD801\uABCD'", SyntaxError);

mathias 2014/10/09 14:45:42 AFAICT, lone surrogates in strings must still be s

Yang 2014/10/09 14:50:18 But they are still not valid identifiers, right?

« test/intl/general/smp-identifier.js ('K') | « test/intl/general/smp-identifier.js ('k') | test/unittests/unicode/unicode-predicates-unittest.cc » ('j') | no next file with comments »