Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/char-predicates.cc

Issue 640193002: Allow identifier code points from supplementary multilingual planes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: add missing file Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/char-predicates.h ('k') | test/unittests/unicode/unicode-predicates-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/char-predicates.cc
diff --git a/src/char-predicates.cc b/src/char-predicates.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ab551d808e69933b8d72b727a4054ebe6595571e
--- /dev/null
+++ b/src/char-predicates.cc
@@ -0,0 +1,42 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
mathias 2014/10/09 10:40:15 2014, no?
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/char-predicates.h"
+
+#ifdef V8_I18N_SUPPORT
+#include "unicode/uchar.h"
+#include "unicode/urename.h"
+#endif // V8_I18N_SUPPORT
+
+namespace v8 {
+namespace internal {
+
+bool SupplementaryPlanes::IsIDStart(uc32 c) {
+ DCHECK(c > 0xFFFF);
+#ifdef V8_I18N_SUPPORT
+ // This only works for code points in the SMPs, since ICU does not exclude
+ // code points with properties 'Pattern_Syntax' or 'Pattern_White_Space'.
+ // Code points in the SMP do not have those properties.
+ return u_isIDStart(c);
+#else
+ // This is incorrect, but if we don't have ICU, use this as fallback.
+ return false;
+#endif // V8_I18N_SUPPORT
+}
+
+
+bool SupplementaryPlanes::IsIDPart(uc32 c) {
+ DCHECK(c > 0xFFFF);
+#ifdef V8_I18N_SUPPORT
+ // This only works for code points in the SMPs, since ICU does not exclude
+ // code points with properties 'Pattern_Syntax' or 'Pattern_White_Space'.
+ // Code points in the SMP do not have those properties.
+ return u_isIDPart(c);
+#else
+ // This is incorrect, but if we don't have ICU, use this as fallback.
+ return false;
+#endif // V8_I18N_SUPPORT
+}
+}
+} // namespace v8::internal
« no previous file with comments | « src/char-predicates.h ('k') | test/unittests/unicode/unicode-predicates-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698