Adds full-functional search results for Athena on Chrome.

Adds full-functional search results for Athena on Chrome.

BUG=380875, 421444
R=oshima@chromium.org, xiyuan@chromium.org
TBR=pkasting@chromium.org, jar@chromium.org
TEST=manually

Committed: https://crrev.com/2ba30fe7f0c4640d3007b3357f0d0ab89637919e
Cr-Commit-Position: refs/heads/master@{#299186}

[xiyuan, 2014-10-09 16:28:54]

LGTM with nits

https://codereview.chromium.org/640103002/diff/40001/athena/home/home_card_im...
File athena/home/home_card_impl.h (right):

https://codereview.chromium.org/640103002/diff/40001/athena/home/home_card_im...
athena/home/home_card_impl.h:50: SearchControllerFactory* search_factory);
nit: scoped_ptr<SearchControllerFactory> to make ownership transfer more
explicit

https://codereview.chromium.org/640103002/diff/40001/athena/home/public/home_...
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/640103002/diff/40001/athena/home/public/home_...
athena/home/public/home_card.h:39: SearchControllerFactory* search_factory);
nit: scoped_ptr<SearchControllerFactory> or document ownership transfer.

https://codereview.chromium.org/640103002/diff/40001/athena/main/public/athen...
File athena/main/public/athena_launcher.h (right):

https://codereview.chromium.org/640103002/diff/40001/athena/main/public/athen...
athena/main/public/athena_launcher.h:37: SearchControllerFactory*
search_factory);
nit: scoped_ptr or document ownership transfer for |search_factory| as well as
|app_model_builder|.

[oshima, 2014-10-09 19:56:40]

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/chrome...
File athena/extensions/chrome/app_list_controller_delegate_athena.cc (right):

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/chrome...
athena/extensions/chrome/app_list_controller_delegate_athena.cc:24: //
TODO(mukai): implement this.
nit: NOTIMPLEMENTED(); 

same for other methods to implement later.

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/shell/...
File athena/extensions/shell/url_search_provider.cc (right):

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/shell/...
athena/extensions/shell/url_search_provider.cc:9: #include
"athena/content/public/scheme_classifier_factory.h"
can we move this to athena/extensions and remove from public interface?

https://codereview.chromium.org/640103002/diff/40001/athena/test/base/athena_...
File athena/test/base/athena_test_helper.cc (right):

https://codereview.chromium.org/640103002/diff/40001/athena/test/base/athena_...
athena/test/base/athena_test_helper.cc:68: NULL);
can't we just use one for shell and remove NULL check? looks like it does not
depend on extensions.

[Jun Mukai, 2014-10-09 21:10:20]

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/chrome...
File athena/extensions/chrome/app_list_controller_delegate_athena.cc (right):

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/chrome...
athena/extensions/chrome/app_list_controller_delegate_athena.cc:24: //
TODO(mukai): implement this.
On 2014/10/09 19:56:39, oshima wrote:
> nit: NOTIMPLEMENTED(); 
> 
> same for other methods to implement later.

Done.

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/shell/...
File athena/extensions/shell/url_search_provider.cc (right):

https://codereview.chromium.org/640103002/diff/40001/athena/extensions/shell/...
athena/extensions/shell/url_search_provider.cc:9: #include
"athena/content/public/scheme_classifier_factory.h"
On 2014/10/09 19:56:40, oshima wrote:
> can we move this to athena/extensions and remove from public interface?

Done. Also, scheme_classifier isn't used in chrome actually, I've removed the
factory and use the instance directly here.

https://codereview.chromium.org/640103002/diff/40001/athena/home/home_card_im...
File athena/home/home_card_impl.h (right):

https://codereview.chromium.org/640103002/diff/40001/athena/home/home_card_im...
athena/home/home_card_impl.h:50: SearchControllerFactory* search_factory);
On 2014/10/09 16:28:53, xiyuan wrote:
> nit: scoped_ptr<SearchControllerFactory> to make ownership transfer more
> explicit

Done.

https://codereview.chromium.org/640103002/diff/40001/athena/home/public/home_...
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/640103002/diff/40001/athena/home/public/home_...
athena/home/public/home_card.h:39: SearchControllerFactory* search_factory);
On 2014/10/09 16:28:53, xiyuan wrote:
> nit: scoped_ptr<SearchControllerFactory> or document ownership transfer.

Done.

https://codereview.chromium.org/640103002/diff/40001/athena/main/public/athen...
File athena/main/public/athena_launcher.h (right):

https://codereview.chromium.org/640103002/diff/40001/athena/main/public/athen...
athena/main/public/athena_launcher.h:37: SearchControllerFactory*
search_factory);
On 2014/10/09 16:28:53, xiyuan wrote:
> nit: scoped_ptr or document ownership transfer for |search_factory| as well as
> |app_model_builder|.

Done.

https://codereview.chromium.org/640103002/diff/40001/athena/test/base/athena_...
File athena/test/base/athena_test_helper.cc (right):

https://codereview.chromium.org/640103002/diff/40001/athena/test/base/athena_...
athena/test/base/athena_test_helper.cc:68: NULL);
On 2014/10/09 19:56:40, oshima wrote:
> can't we just use one for shell and remove NULL check? looks like it does not
> depend on extensions.

Done.

[Jun Mukai, 2014-10-09 21:11:11]

I noticed that this cannot be landed, because omnibox search result tries to
open through browser_navigator. I'll create a fix for this.

[Jun Mukai, 2014-10-09 23:24:15]

updated based on https://codereview.chromium.org/644863002/

[Jun Mukai, 2014-10-10 17:06:37]

Now it's safe to land this.

[Jun Mukai, 2014-10-10 17:07:02]

mukai@chromium.org changed reviewers:
+ jar@chromium.org, pkasting@chromium.org

[Jun Mukai, 2014-10-10 17:13:16]

TBR-ing pkasting, jar for moving DEPS entries.

[Jun Mukai, 2014-10-10 17:13:20]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-10 17:13:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640103002/370001

[commit-bot: I haz the power, 2014-10-10 17:22:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 17:22:52]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Peter Kasting, 2014-10-10 17:35:27]

On 2014/10/10 17:13:16, Jun Mukai wrote:
> TBR-ing pkasting, jar for moving DEPS entries.

All the DEPS changes here seem to be about athena/.  I know literally nothing
about athena/.  If I'm in any kind of an OWNERS file in there, please remove me.
 Otherwise, I'm not really sure how you chose me to be CCed.

[Jun Mukai, 2014-10-10 17:38:05]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-10 17:39:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640103002/590001

[Jun Mukai, 2014-10-10 17:41:40]

On 2014/10/10 17:35:27, Peter Kasting wrote:
> On 2014/10/10 17:13:16, Jun Mukai wrote:
> > TBR-ing pkasting, jar for moving DEPS entries.
> 
> All the DEPS changes here seem to be about athena/.  I know literally nothing
> about athena/.  If I'm in any kind of an OWNERS file in there, please remove
me.
>  Otherwise, I'm not really sure how you chose me to be CCed.

This CL adds +components/omnibox (and some other your owning components) to
athena/extensions/shell/DEPS.  That usually requires +components/omnibox owner's
approval in addition to athena owners approval (don't ask me why...)
I'm skipping with TBR because this addition is fake, it's actually moved from
athena/main/DEPS.

[commit-bot: I haz the power, 2014-10-10 18:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 18:52:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jun Mukai, 2014-10-10 20:40:25]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-10 20:41:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640103002/590001

[commit-bot: I haz the power, 2014-10-10 21:08:03]

Committed patchset #7 (id:590001)

[commit-bot: I haz the power, 2014-10-10 21:08:46]

Patchset 7 (id:??) landed as
https://crrev.com/2ba30fe7f0c4640d3007b3357f0d0ab89637919e
Cr-Commit-Position: refs/heads/master@{#299186}