Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java

Issue 640093003: Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reverting previous changes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java b/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
index ffb03af20e7887bdd6079bf3db6c80f70e4f92de..f0b15e8e899525c8c9cc3dd8d5d5d742bb9b8067 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
@@ -4,6 +4,7 @@
package org.chromium.content.browser.input;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.graphics.Canvas;
import android.graphics.drawable.Drawable;
@@ -121,6 +122,7 @@ public class PopupTouchHandleDrawable extends View {
};
}
+ @SuppressLint("ClickableViewAccessibility")
@Override
public boolean onTouchEvent(MotionEvent event) {
final PopupTouchHandleDrawableDelegate delegate = mDelegate.get();
@@ -205,7 +207,7 @@ public class PopupTouchHandleDrawable extends View {
setVisibility(visible ? VISIBLE : INVISIBLE);
}
- private void updateAlpha() {
+ private void updateAlpha() {
if (mAlpha == 1.f) return;
long currentTimeMillis = AnimationUtils.currentAnimationTimeMillis();
mAlpha = Math.min(1.f, (float) (currentTimeMillis - mFadeStartTime) / FADE_IN_DURATION_MS);
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698