chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java - Issue 640093003: Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

Issue 640093003: Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reverting previous changes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java ('k') | content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

index 42f5ed23a95b9ac7504a3b6db91c21488ae99788..386026c14278e08e2316069312be01047be8b325 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.shell;

+import android.annotation.SuppressLint;

import android.content.Context;

import android.content.res.Configuration;

import android.graphics.drawable.ClipDrawable;

@@ -189,6 +190,7 @@ public class ChromeShellToolbar extends LinearLayout {

}

});

menuButton.setOnTouchListener(new OnTouchListener() {

+ @SuppressLint("ClickableViewAccessibility")

@Override

public boolean onTouch(View view, MotionEvent event) {

return mAppMenuButtonHelper != null && mAppMenuButtonHelper.onTouch(view, event);