Resolve lint warnings related to ClickableViewAccessibility when a class overrides onTouch event.

content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.Context;
 import android.graphics.Canvas;
 import android.graphics.drawable.Drawable;
 import android.view.MotionEvent;
@@ skipping 41 matching lines @@
     private float mHotspotY;
 
     private float mAlpha;
 
     private final int[] mTempScreenCoords = new int[2];
 
     static final int LEFT = 0;
     static final int CENTER = 1;
     static final int RIGHT = 2;
     private int mOrientation = -1;
+    private boolean mDownTouch = false;
 
     /**
      * Provides additional interaction behaviors necessary for handle
      * manipulation and interaction.
      */
     public interface PopupTouchHandleDrawableDelegate {
         /**
          * @return The parent View of the PopupWindow.
          */
         View getParent();
@@ skipping 38 matching lines @@
 
         // Convert from PopupWindow local coordinates to
         // parent view local coordinates prior to forwarding.
         delegate.getParent().getLocationOnScreen(mTempScreenCoords);
         final float offsetX = event.getRawX() - event.getX() - mTempScreenCoords[0];
         final float offsetY = event.getRawY() - event.getY() - mTempScreenCoords[1];
         final MotionEvent offsetEvent = MotionEvent.obtainNoHistory(event);
         offsetEvent.offsetLocation(offsetX, offsetY);
         final boolean handled = delegate.onTouchHandleEvent(offsetEvent);
         offsetEvent.recycle();
+        // Listening for the down and up touch events
+        // to enable accessibility services for a user
+        // who cannot click touch screen.
+        switch (event.getAction()) {
+        case MotionEvent.ACTION_DOWN:
+            mDownTouch = true;
+            break;
+        case MotionEvent.ACTION_UP:
+            if (mDownTouch) {
+                mDownTouch = false;
+                performClick();

[newt (away), 2014/10/20 22:20:53]

This isn't how performClick() should be used. See the comment "// Handle the
action for the custom click here" on
http://developer.android.com/guide/topics/ui/accessibility/apps.html

The point of performClick() is that you handle the click *inside of*
performClick() so that accessibility apps can call performClick() directly to
simulate a click on that View while bypassing onTouchEvent().

Implementing accessibility for this view looks rather complicated, however,
because we need to handle dragging, not clicking.

jdduke: Can we make this accessible?

[jdduke (slow), 2014/10/20 23:06:17]

I'm not familiar (at all) with Android's accesibility conventions, but it seems
like this could be made accessible by having |performClick()| inject an
ACTION_DOWN + ACTION_UP motion event into |OnTouchEvent|, probably with a
location that is in the middle of the drawable. Or should that logic go in
|onClick()|?

The accessibility docs say it should be other way around (onTouchEvent should
call performClick), but that doesn't make a lot of sense here. If we implement
the logic I suggested, we could probably suppress the associated warnings.

[wajahat, 2014/10/21 14:34:56]

So going with the comments, it is ok to suppress the warnings for now

+            }
+        }
         return handled;
     }
 
+    @Override
+    public boolean performClick() {
+        super.performClick();
+        return true;
+    }
+
     private void setOrientation(int orientation) {
         assert orientation >= LEFT && orientation <= RIGHT;
         if (mOrientation == orientation) return;
 
         final boolean hadValidOrientation = mOrientation != -1;
         mOrientation = orientation;
 
         final int oldAdjustedPositionX = getAdjustedPositionX();
         final int oldAdjustedPositionY = getAdjustedPositionY();
 
@@ skipping 155 matching lines @@
     private boolean intersectsWith(float x, float y, float width, float height) {
         if (mDrawable == null) return false;
         final int drawableWidth = mDrawable.getIntrinsicWidth();
         final int drawableHeight = mDrawable.getIntrinsicHeight();
         return !(x >= mPositionX + drawableWidth
                 || y >= mPositionY + drawableHeight
                 || x + width <= mPositionX
                 || y + height <= mPositionY);
     }
 }