Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640093002: change newly added OVERRIDE to override in sync/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

change newly added OVERRIDE to override in sync/ BUG=417463 Committed: https://crrev.com/f2c779a48121afb03a63f5799e36dfee31bac62c Cr-Commit-Position: refs/heads/master@{#298929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M sync/internal_api/attachments/attachment_store_handle_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_store_handle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/attachments/in_memory_attachment_store.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Nicholas: please take a look at this additional OVERRIDE replacement.
6 years, 2 months ago (2014-10-08 22:43:29 UTC) #2
Nicolas Zea
lgtm
6 years, 2 months ago (2014-10-09 16:34:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640093002/1
6 years, 2 months ago (2014-10-09 16:45:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 17:34:27 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 17:35:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f2c779a48121afb03a63f5799e36dfee31bac62c
Cr-Commit-Position: refs/heads/master@{#298929}

Powered by Google App Engine
This is Rietveld 408576698