Issue 640083002: Define ABORT_PROVIDED when building for NaCl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 640083002: Define ABORT_PROVIDED when building for NaCl (Closed)

Created:
6 years, 2 months ago by Derek Schuff

Modified:
6 years, 2 months ago

Reviewers:
Mark Seaborn, Roland McGrath

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/nacl-newlib.git@master

Visibility:
Public.

Define ABORT_PROVIDED when building for NaCl libnacl provides a version of abort that exits via a trap rather than calling exit(1); this is is more useful for debugging. Define ABORT_PROVIDED so that we always use the version from libnacl instead of newlib's. R=mcgrathr@chromium.org, mseaborn@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3946 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3248 Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=43fdb6b573da6189934a4eefc821bdfe22cf247e

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	newlib/configure.host	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Mark Seaborn

LGTM. You can also set BUG= https://code.google.com/p/nativeclient/issues/detail?id=3248

6 years, 2 months ago (2014-10-08 22:49:47 UTC) #4

Derek Schuff

6 years, 2 months ago (2014-10-09 16:34:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
43fdb6b573da6189934a4eefc821bdfe22cf247e (tree was closed).