Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: cc/resources/tile_manager_unittest.cc

Issue 640063010: cc: Don't swap PictureLayerTilingSet on activate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: noswap: perftest Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager_unittest.cc
diff --git a/cc/resources/tile_manager_unittest.cc b/cc/resources/tile_manager_unittest.cc
index 49a93d3d1296ee2a8bd46f7d6df8032247d337e6..715306e7d411994b045dcd95dff31304211afec3 100644
--- a/cc/resources/tile_manager_unittest.cc
+++ b/cc/resources/tile_manager_unittest.cc
@@ -109,10 +109,10 @@ class TileManagerTilePriorityQueueTest : public testing::Test {
if (old_pending_root) {
pending_layer.reset(
static_cast<FakePictureLayerImpl*>(old_pending_root.release()));
- pending_layer->SetRasterSource(pile);
+ pending_layer->SetRasterSourceOnPending(pile, Region(), false);
} else {
- pending_layer =
- FakePictureLayerImpl::CreateWithRasterSource(pending_tree, id_, pile);
+ pending_layer = FakePictureLayerImpl::CreateWithRasterSource(
+ pending_tree, id_, pile, false);
pending_layer->SetDrawsContent(true);
}
// The bounds() just mirror the pile size.
@@ -124,14 +124,6 @@ class TileManagerTilePriorityQueueTest : public testing::Test {
pending_layer_->DoPostCommitInitializationIfNeeded();
}
- void CreateHighLowResAndSetAllTilesVisible() {
- // Active layer must get updated first so pending layer can share from it.
- active_layer_->CreateDefaultTilingsAndTiles();
- active_layer_->SetAllTilesVisible();
- pending_layer_->CreateDefaultTilingsAndTiles();
- pending_layer_->SetAllTilesVisible();
- }
-
TileManager* tile_manager() { return host_impl_.tile_manager(); }
protected:
@@ -344,8 +336,8 @@ TEST_F(TileManagerTilePriorityQueueTest, ActivationComesBeforeEventually) {
scoped_refptr<FakePicturePileImpl> pending_pile =
FakePicturePileImpl::CreateFilledPile(tile_size, gfx::Size(1000, 1000));
scoped_ptr<FakePictureLayerImpl> pending_child =
- FakePictureLayerImpl::CreateWithRasterSource(host_impl_.pending_tree(),
- id_ + 1, pending_pile);
+ FakePictureLayerImpl::CreateWithRasterSource(
+ host_impl_.pending_tree(), id_ + 1, pending_pile, false);
pending_layer_->AddChild(pending_child.Pass());
FakePictureLayerImpl* pending_child_raw = static_cast<FakePictureLayerImpl*>(
host_impl_.pending_tree()->LayerById(id_ + 1));
@@ -567,7 +559,7 @@ TEST_F(TileManagerTilePriorityQueueTest,
scoped_ptr<FakePictureLayerImpl> pending_child =
FakePictureLayerImpl::CreateWithRasterSource(host_impl_.pending_tree(), 2,
- pending_pile);
+ pending_pile, false);
pending_layer_->AddChild(pending_child.Pass());
FakePictureLayerImpl* pending_child_layer =
@@ -681,7 +673,7 @@ TEST_F(TileManagerTilePriorityQueueTest,
scoped_ptr<FakePictureLayerImpl> pending_child =
FakePictureLayerImpl::CreateWithRasterSource(host_impl_.pending_tree(), 2,
- pending_pile);
+ pending_pile, false);
pending_layer_->AddChild(pending_child.Pass());
// Create a fully transparent child layer so that its tile priorities are not

Powered by Google App Engine
This is Rietveld 408576698