Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 640063008: Revert of Implemented OwnerSettingsService::Set() method. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Implemented OwnerSettingsService::Set() method. (patchset #7 id:160001 of https://codereview.chromium.org/654263003/) Reason for revert: ASAN bot unhappy http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/3731 Original issue's description: > Implemented OwnerSettingsService::Set() method. > > BUG=230018 > TEST=unit_tests:OwnerSettingsServiceChromeOSTest.* > > Committed: https://crrev.com/5fa0ee22683b92d67e07c060e8c7a3c4cced51ee > Cr-Commit-Position: refs/heads/master@{#301132} TBR=mnissler@chromium.org,pastarmovj@chromium.org,ygorshenin@chromium.org NOTREECHECKS=true NOTRY=true BUG=230018 Committed: https://crrev.com/5e64220166aa85f47fa9b8dd5db53254bc95487f Cr-Commit-Position: refs/heads/master@{#301161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -833 lines) Patch
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 7 chunks +19 lines, -58 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 9 chunks +67 lines, -361 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 4 chunks +2 lines, -24 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.h View 6 chunks +24 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 8 chunks +278 lines, -56 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 6 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 12 chunks +67 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/ownership/owner_settings_service.h View 5 chunks +8 lines, -47 lines 0 comments Download
M components/ownership/owner_settings_service.cc View 5 chunks +10 lines, -47 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Implemented OwnerSettingsService::Set() method.
6 years, 2 months ago (2014-10-24 19:03:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640063008/1
6 years, 2 months ago (2014-10-24 19:05:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 19:07:27 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 19:08:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e64220166aa85f47fa9b8dd5db53254bc95487f
Cr-Commit-Position: refs/heads/master@{#301161}

Powered by Google App Engine
This is Rietveld 408576698