cc/animation/scrollbar_animation_controller_linear_fade.cc - Issue 640063002: Hide scrollbars when their dimensions are not scrollable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/scrollbar_animation_controller_linear_fade.cc

Issue 640063002: Hide scrollbars when their dimensions are not scrollable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added unit tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc » ('j') | cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/animation/scrollbar_animation_controller_linear_fade.cc

diff --git a/cc/animation/scrollbar_animation_controller_linear_fade.cc b/cc/animation/scrollbar_animation_controller_linear_fade.cc

index 90437b3835b322c09649fe35d024d603d05bcc0b..f65fd727ac4fe50f9c8666ac3489a8426eb59b6a 100644

--- a/cc/animation/scrollbar_animation_controller_linear_fade.cc

+++ b/cc/animation/scrollbar_animation_controller_linear_fade.cc

@@ -62,8 +62,9 @@ void ScrollbarAnimationControllerLinearFade::ApplyOpacityToScrollbars(

it != scrollbars->end();

++it) {

ScrollbarLayerImplBase* scrollbar = *it;

if (scrollbar->is_overlay_scrollbar())

- scrollbar->SetOpacity(opacity);

+ scrollbar->SetOpacity(scrollbar->can_scroll_orientation() ? opacity : 0);

}