Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 640033003: Don't call SetProperty on the plugin unless HasProperty is true (Closed)

Created:
6 years, 2 months ago by raymes
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't call SetProperty on the plugin unless HasProperty is true The default implementation of SetProperty in the plugin (inside ScriptableObject) will throw an exception. This can result in an unexpected exception in JS when properties are set on the plugin element. We should only call SetProperty if the plugin has that property. BUG=414842 TBR=dmichael@chromium.org Committed: https://crrev.com/0b40913d6e0cff095e373ea216680870d1215336 Cr-Commit-Position: refs/heads/master@{#299040}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/renderer/pepper/plugin_object.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
raymes
6 years, 2 months ago (2014-10-10 00:42:25 UTC) #2
Sam McNally
lgtm
6 years, 2 months ago (2014-10-10 00:57:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640033003/30001
6 years, 2 months ago (2014-10-10 00:59:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:30001)
6 years, 2 months ago (2014-10-10 02:05:44 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0b40913d6e0cff095e373ea216680870d1215336 Cr-Commit-Position: refs/heads/master@{#299040}
6 years, 2 months ago (2014-10-10 02:06:22 UTC) #7
dmichael (off chromium)
6 years, 2 months ago (2014-10-10 15:40:02 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698